[PATCH] nl80211: don't document per-wiphy interface dump

[PATCH] nl80211: don't document per-wiphy interface dump

[Johannes Berg]

From: Johannes Berg <johannes.berg@intel.com>

Such a feature doesn't exist and isn't really needed since you
probably won't have enough interfaces to make it worthwhile, so
just remove that from the documentation.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 include/uapi/linux/nl80211.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
index 1cbc3aae425c..68b294e83944 100644
--- a/include/uapi/linux/nl80211.h
+++ b/include/uapi/linux/nl80211.h
@@ -180,8 +180,8 @@
  *	%NL80211_ATTR_WIPHY and %NL80211_ATTR_WIPHY_NAME.
  *
  * @NL80211_CMD_GET_INTERFACE: Request an interface's configuration;
- *	either a dump request on a %NL80211_ATTR_WIPHY or a specific get
- *	on an %NL80211_ATTR_IFINDEX is supported.
+ *	either a dump request for all interfaces or a specific get with a
+ *	single %NL80211_ATTR_IFINDEX is supported.
  * @NL80211_CMD_SET_INTERFACE: Set type of a virtual interface, requires
  *	%NL80211_ATTR_IFINDEX and %NL80211_ATTR_IFTYPE.
  * @NL80211_CMD_NEW_INTERFACE: Newly created virtual interface or response
-- 
2.1.4

Re: [PATCH] nl80211: don't document per-wiphy interface dump

[Marcel Holtmann]

Hi Johannes,

> Such a feature doesn't exist and isn't really needed since you
> probably won't have enough interfaces to make it worthwhile, so
> just remove that from the documentation.
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> include/uapi/linux/nl80211.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
> index 1cbc3aae425c..68b294e83944 100644
> --- a/include/uapi/linux/nl80211.h
> +++ b/include/uapi/linux/nl80211.h
> @@ -180,8 +180,8 @@
>  *	%NL80211_ATTR_WIPHY and %NL80211_ATTR_WIPHY_NAME.
>  *
>  * @NL80211_CMD_GET_INTERFACE: Request an interface's configuration;
> - *	either a dump request on a %NL80211_ATTR_WIPHY or a specific get
> - *	on an %NL80211_ATTR_IFINDEX is supported.
> + *	either a dump request for all interfaces or a specific get with a
> + *	single %NL80211_ATTR_IFINDEX is supported.
>  * @NL80211_CMD_SET_INTERFACE: Set type of a virtual interface, requires
>  *	%NL80211_ATTR_IFINDEX and %NL80211_ATTR_IFTYPE.
>  * @NL80211_CMD_NEW_INTERFACE: Newly created virtual interface or response

we had a TODO item internally that planned to implement this actually.

Regards

Marcel

Re: [PATCH] nl80211: don't document per-wiphy interface dump

[Johannes Berg]

On Thu, 2015-01-29 at 08:02 -0800, Marcel Holtmann wrote:

> > Such a feature doesn't exist and isn't really needed since you
> > probably won't have enough interfaces to make it worthwhile, so
> > just remove that from the documentation.

> we had a TODO item internally that planned to implement this actually.

I'm not sure what it buys you since you still have to deal with old
kernels and do the filtering, and there aren't that many messages
(typically you only have one NIC anyway), but hey, if you have enough
time to waste on it I guess I don't mind ... Although we should start
watching nl80211.c code size a bit more I guess :)

Can always include a revert of this in the change that actually adds it.

johannes