From: Johannes Berg <johannes@sipsolutions.net>
To: Peter Oh <poh@codeaurora.org>
Cc: Peter Oh <poh@qca.qualcomm.com>,
linux-wireless@vger.kernel.org, Bob Copeland <me@bobcopeland.com>,
ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Replace ioread with wmb for data sync
Date: Mon, 02 Feb 2015 20:22:19 +0100 [thread overview]
Message-ID: <1422904939.8755.3.camel@sipsolutions.net> (raw)
In-Reply-To: <54CFCCCF.900@codeaurora.org>
> > You basically have the following sequence:
> >
> > iowrite()
> > ioread()
> >
> > If you look, you'll see that iowrite() is actually done (or should be,
> > or perhaps with appropriate syncs) on an uncached mapping.
> since it's mmio, iowrite will be map to write, not out which is cached
> mapping.
> That's why we address "posted write" here.
> If it's un-cached mapping which is volatile, we don't even need ioread.
No, this isn't true - "posted write" in the context of this discussion
is about the PCIe bus. Memory writes that go through cache aren't
referred to as "posted writes", those are just (cached) memory writes.
> > As a result,
> > the only thing you care about here is the PCIe bus, not the CPU cache
> > flush. And from there on that's just a question of PCIe bus semantics.
> So how does ioread guarantee PCIe bus transaction done?
That's how PCIe works, operations are serialized, and read() has to wait
for a response from the device (but write doesn't - which is "posted
write")
johannes
next prev parent reply other threads:[~2015-02-02 19:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 22:25 [PATCH] ath10k: Replace ioread with wmb for data sync Peter Oh
2015-01-27 21:33 ` Bob Copeland
2015-01-27 23:53 ` Peter Oh
2015-01-28 4:30 ` Bob Copeland
2015-01-28 5:39 ` Peter Oh
2015-01-28 7:37 ` Johannes Berg
2015-01-30 22:53 ` Peter Oh
2015-01-31 1:16 ` Sujith Manoharan
2015-01-31 1:56 ` Peter Oh
2015-01-31 2:06 ` Sujith Manoharan
2015-02-02 17:25 ` Peter Oh
2015-02-02 22:26 ` Adrian Chadd
2015-02-02 23:04 ` Peter Oh
2015-02-02 13:02 ` Johannes Berg
2015-02-02 17:33 ` Peter Oh
2015-02-02 18:54 ` Johannes Berg
2015-02-02 19:15 ` Peter Oh
2015-02-02 19:22 ` Johannes Berg [this message]
2015-02-02 19:36 ` Peter Oh
2015-02-02 19:47 ` Johannes Berg
2015-02-02 22:06 ` Peter Oh
2015-02-02 23:25 ` Florian Fainelli
2015-02-02 23:49 ` Peter Oh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422904939.8755.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
--cc=poh@codeaurora.org \
--cc=poh@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).