From: Johannes Berg <johannes@sipsolutions.net>
To: Dedy Lansky <dlansky@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
'Vladimir Kondratiev' <qca_vkondrat@qca.qualcomm.com>
Subject: Re: [PATCH] cfg80211: PBSS basic support
Date: Fri, 06 Feb 2015 20:35:13 +0100 [thread overview]
Message-ID: <1423251313.2037.30.camel@sipsolutions.net> (raw)
In-Reply-To: <002801d03a40$55b81630$01284290$@codeaurora.org>
Hi,
Sorry about the delay.
> > > wdev->bss_type refers to the BSS that we are connecting/connected to (Maybe rename to "conn_bss_type"?).
> > > This member is used in sme.c. It was introduced because once the connect is complete and driver calls cfg80211_connect_result(), cfg needs to find the BSS being connected to.
> >
> > Ok I was thinking you were adding it to struct cfg80211_bss. Wouldn't that make a bit more sense? Of course it can also be derived from cfg80211_bss::channel and cfg80211_bss::capability, your call.
> >
> > However, it doesn't seem that you need it in wdev if you have it there inside wdev->current_bss?
>
> current_bss is set later.
>
> inside __cfg80211_connect_result(), we look for the BSS being connected to:
> bss = cfg80211_get_bss(..., bssid, wdev->bss_type, ...)
> only after that, current_bss is set to this BSS:
> wdev->current_bss = bss_from_pub(bss);
Ok.
johannes
prev parent reply other threads:[~2015-02-06 19:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 7:55 [PATCH] cfg80211: PBSS basic support Dedy Lansky
2015-01-27 8:24 ` Johannes Berg
2015-01-27 10:50 ` Dedy Lansky
2015-01-27 11:01 ` Johannes Berg
2015-01-27 14:48 ` Dedy Lansky
2015-02-06 19:35 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423251313.2037.30.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dlansky@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=qca_vkondrat@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).