linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Avinash Patil <patila@marvell.com>
Cc: linux-wireless@vger.kernel.org, akarwar@marvell.com,
	cluo@marvell.com, huxm@marvell.com, Li Long <longli@marvell.com>
Subject: Re: [PATCH 1/3] mwifiex: add cfg80211 set_default_mgmt_key handler
Date: Fri, 13 Feb 2015 19:06:55 +0100	[thread overview]
Message-ID: <1423850815.2936.4.camel@sipsolutions.net> (raw)
In-Reply-To: <1423764954-30412-1-git-send-email-patila@marvell.com> (sfid-20150212_134627_640778_2A1810BC)

On Thu, 2015-02-12 at 23:45 +0530, Avinash Patil wrote:
> From: Xinming Hu <huxm@marvell.com>
> 
> It is observed that hostapd failed to setup with management frame
> protection mode enabled when using mwifiex.
> 
> This is because hostapd will try to install IGTK using
> cfg80211 set_default_mgmt_key handler.
> 
> we have already support IGTK install in set_key handler, so just work
> around this issue by add an empty cfg80211_set_default_mgmt_key handler.

I believe that this is incorrect since the key should only be installed
for TX after this handler, not in the set_key handler. This should make
a difference in the case of rekeying? Perhaps hostapd doesn't actually
program the key until rekeying with all stations finishes though.

johannes


  parent reply	other threads:[~2015-02-13 18:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12 18:15 [PATCH 1/3] mwifiex: add cfg80211 set_default_mgmt_key handler Avinash Patil
2015-02-12 18:15 ` [PATCH 2/3] mwifiex: WMM AC parameter configuration for AP mode Avinash Patil
2015-02-12 18:15 ` [PATCH 3/3] mwifiex: add cfg80211 set_mac_acl handler " Avinash Patil
2015-02-13 18:06 ` Johannes Berg [this message]
2015-02-23  7:47   ` [PATCH 1/3] mwifiex: add cfg80211 set_default_mgmt_key handler Avinash Patil
2015-03-17 11:25   ` Avinash Patil
2015-03-31 14:33   ` Avinash Patil
2015-03-31 14:59     ` Jouni Malinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423850815.2936.4.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=akarwar@marvell.com \
    --cc=cluo@marvell.com \
    --cc=huxm@marvell.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=longli@marvell.com \
    --cc=patila@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).