From: Johannes Berg <johannes@sipsolutions.net>
To: Vladimir Kondratiev <QCA_vkondrat@QCA.qualcomm.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] zero-copy AMSDU processing
Date: Mon, 23 Feb 2015 09:35:39 +0100 [thread overview]
Message-ID: <1424680539.2782.1.camel@sipsolutions.net> (raw)
In-Reply-To: <1708052.J876aMsZU2@lx-wigig-72> (sfid-20150219_115139_326083_61D4FCF7)
On Thu, 2015-02-19 at 12:51 +0200, Vladimir Kondratiev wrote:
> I am looking for ideas how can one process AMSDU in the software, without copying data.
> Current implementation like ieee80211_amsdu_to_8023s() do copy packet data.
>
> Assume I got in the driver, MPDU that is AMSDU containing several MSDU's.
> It is in the single memory buffer that was allocated for DMA.
> Can I construct skb's per MSDU with minimal data copy, having most of the
> original data in place? Any ideas for this?
As you noticed, this implementation is very inefficient.
If the SKB has pages (rather than being linear, as
ieee80211_amsdu_to_8023s() assumes) then what Emmanuel said would
probably be the best approach, although it could be possible that would
mess up truesize accounting and lead to lower performance. Certainly
you'd want to do it only for suitably large packets (at least bigger
than 128 bytes or so)
johannes
next prev parent reply other threads:[~2015-02-23 8:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 10:51 [RFC] zero-copy AMSDU processing Vladimir Kondratiev
2015-02-19 11:35 ` Emmanuel Grumbach
2015-02-23 8:35 ` Johannes Berg [this message]
2015-02-25 7:07 ` Vladimir Kondratiev
2015-02-25 7:52 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424680539.2782.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=QCA_vkondrat@QCA.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).