linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] mac80211_hwsim: notify user-space about channel change.
Date: Mon, 23 Feb 2015 12:49:15 +0100	[thread overview]
Message-ID: <1424692155.2782.6.camel@sipsolutions.net> (raw)
In-Reply-To: <1424217588-29558-1-git-send-email-greearb@candelatech.com> (sfid-20150218_005956_617537_D2A9B91F)

On Tue, 2015-02-17 at 15:59 -0800, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
> 
> The goal is to allow the user-space application to properly
> filter packets before sending them down to the kernel.  This
> should more closely mimic what a real piece of hardware would
> do.

> + * @HWSIM_CMD_NOTIFY: notify user-space about driver changes.  This is
> + * designed to help the user-space app better emulate radio hardware.
> + * This command uses:
> + *      %HWSIM_ATTR_FREQ # Notify current operating center frequency.
> + *      %HWSIM_ATTR_ADDR_TRANSMITTER # ID which radio we are notifying about.
>   * @__HWSIM_CMD_MAX: enum limit

This seems a bit strange - don't we already tag packets with the
frequency? Why would you need the channel change separately? What does
that even mean? Depending on how you use this it could entirely break
off-channel operation, for example.

johannes


  reply	other threads:[~2015-02-23 11:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-17 23:59 [RFC] mac80211_hwsim: notify user-space about channel change greearb
2015-02-23 11:49 ` Johannes Berg [this message]
2015-02-23 17:43   ` Ben Greear
2015-02-24 10:11     ` Johannes Berg
2015-02-24 14:36       ` Ben Greear
2015-02-24 14:40         ` Johannes Berg
2015-03-11 21:05           ` Ben Greear
2015-03-31 14:27             ` Johannes Berg
2015-03-31 15:56               ` Ben Greear
2015-04-14  8:13                 ` Johannes Berg
2015-04-14 14:56                   ` Ben Greear
2015-04-14 15:06                     ` Johannes Berg
2015-04-14 15:55                       ` Ben Greear
2015-04-15  9:33                         ` Johannes Berg
2015-04-15 15:06                           ` Ben Greear
2015-04-17 11:25                             ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424692155.2782.6.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).