From: Johannes Berg <johannes@sipsolutions.net>
To: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Thomas Graf <tgraf@suug.ch>
Subject: Re: [RFC] mac80211: use rhashtable for station table
Date: Mon, 23 Feb 2015 17:33:55 +0100 [thread overview]
Message-ID: <1424709235.3075.22.camel@sipsolutions.net> (raw)
In-Reply-To: <CAHNKnsSm1GOUMONPB4oB1tJ-OeWOG1XOhw=HEY8LPXhDEHEjbg@mail.gmail.com> (sfid-20150214_031521_538381_CAA3F347)
On Sat, 2015-02-14 at 05:14 +0300, Sergey Ryazanov wrote:
> A nice change! Couple of years ago I did some tests with real sets of
> MACs and jhash gives a better distribution than usage of a last octet.
>
> BTW, why do you use full address and generic jhash? Hashing of two
> least significant words could be faster. Isn't it?
Well - not sure what you're trying to say? First you're saying jhash()
was clearly better and then you're saying I shouldn't use it? ;-)
Anyway - just using the last two bytes (or even 16-bit words) won't
cover the case where the locally administered bit is set in an otherwise
unchanged address, which is getting more common for P2P.
I also don't really see any major drawbacks to hashing it all?
johannes
next prev parent reply other threads:[~2015-02-23 16:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 21:47 [RFC] mac80211: use rhashtable for station table Johannes Berg
2015-02-13 22:13 ` Ben Greear
2015-02-23 16:32 ` Johannes Berg
2015-02-14 2:14 ` Sergey Ryazanov
2015-02-23 16:33 ` Johannes Berg [this message]
2015-02-23 21:26 ` Sergey Ryazanov
2015-02-23 21:52 ` Johannes Berg
2015-02-23 22:01 ` Johannes Berg
2015-02-23 22:07 ` Johannes Berg
2015-02-23 22:15 ` Sergey Ryazanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424709235.3075.22.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=ryazanov.s.a@gmail.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).