From: Johannes Berg <johannes@sipsolutions.net>
To: Masashi Honma <masashi.honma@gmail.com>
Cc: linux-wireless@vger.kernel.org, me@bobcopeland.com
Subject: Re: [PATCH v4] mac80211: Allow 0 for NL80211_MESHCONF_PLINK_TIMEOUT to disable STA expiration
Date: Tue, 24 Feb 2015 10:46:11 +0100 [thread overview]
Message-ID: <1424771171.2192.3.camel@sipsolutions.net> (raw)
In-Reply-To: <1423016529-4812-1-git-send-email-masashi.honma@gmail.com> (sfid-20150204_032242_077760_F0B21BD8)
Hi,
Sorry about the late reply! I'm getting back to merging now and taking a
closer look at this issue.
> +++ b/net/wireless/nl80211.c
> @@ -5261,7 +5261,7 @@ do { \
> FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshAwakeWindowDuration,
> 0, 65535, mask,
> NL80211_MESHCONF_AWAKE_WINDOW, nla_get_u16);
> - FILL_IN_MESH_PARAM_IF_SET(tb, cfg, plink_timeout, 1, 0xffffffff,
> + FILL_IN_MESH_PARAM_IF_SET(tb, cfg, plink_timeout, 0, 0xffffffff,
> mask, NL80211_MESHCONF_PLINK_TIMEOUT,
I think you should document this new behaviour also in nl80211.h.
Additionally - what's the plan on how to discover this? Should userspace
just try to set with 0 value and then drop back to some big number if it
gets an error?
johannes
next prev parent reply other threads:[~2015-02-24 9:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 5:17 [PATCH] mesh: Avoid STA expiration timer truncation to u32 Masashi Honma
2015-01-16 5:49 ` Kalle Valo
2015-01-16 6:12 ` Masashi Honma
2015-01-16 6:18 ` [PATCH v2] mac80211: " Masashi Honma
2015-01-16 13:31 ` Bob Copeland
2015-01-20 2:44 ` Masashi Honma
2015-01-20 2:47 ` [PATCH v3] " Masashi Honma
2015-01-23 9:42 ` Johannes Berg
2015-01-23 14:27 ` Masashi Honma
2015-02-04 2:22 ` [PATCH v4] mac80211: Allow 0 for NL80211_MESHCONF_PLINK_TIMEOUT to disable STA expiration Masashi Honma
2015-02-24 9:46 ` Johannes Berg [this message]
[not found] ` <CAFk-A4nyEvsaCah97ohnbLW7a0+GRbnuJGLyFkBLbpWVffn85w@mail.gmail.com>
2015-02-24 10:03 ` Fwd: " Masashi Honma
2015-02-24 13:42 ` [PATCH v5] " Masashi Honma
2015-02-24 20:08 ` Johannes Berg
2015-02-24 23:24 ` Masashi Honma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424771171.2192.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=masashi.honma@gmail.com \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).