From: Johannes Berg <johannes@sipsolutions.net>
To: Bob Copeland <me@bobcopeland.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211_hwsim: support any address in userspace
Date: Tue, 24 Feb 2015 11:15:20 +0100 [thread overview]
Message-ID: <1424772920.2192.20.camel@sipsolutions.net> (raw)
In-Reply-To: <1424705624-7964-1-git-send-email-me@bobcopeland.com> (sfid-20150223_163628_160158_62E4F7CC)
On Mon, 2015-02-23 at 10:33 -0500, Bob Copeland wrote:
> Due to the checks in get_hwsim_data_ref_from_addr, wmediumd
> was only able to use the second mac address (those starting with
> 0x42). This is confusing and needlessly limiting, so allow any
> configured address.
>
> While at it, use ether_addr_equal since data->addresses and the
> address from the netlink payload are aligned(2).
As I mentioned on IRC, I think you should iterate the interfaces to
identify the currently live MAC addresses instead of the fake "hw
addresses" we assign to each hwsim radio.
johannes
prev parent reply other threads:[~2015-02-24 10:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 15:33 [PATCH] mac80211_hwsim: support any address in userspace Bob Copeland
2015-02-24 10:15 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424772920.2192.20.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).