From: Johannes Berg <johannes@sipsolutions.net>
To: Vladimir Kondratiev <QCA_vkondrat@QCA.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, Emmanuel Grumbach <egrumbach@gmail.com>
Subject: Re: [RFC] zero-copy AMSDU processing
Date: Wed, 25 Feb 2015 08:52:16 +0100 [thread overview]
Message-ID: <1424850736.2050.0.camel@sipsolutions.net> (raw)
In-Reply-To: <3723348.23HgaGqW1o@lx-wigig-72>
On Wed, 2015-02-25 at 09:07 +0200, Vladimir Kondratiev wrote:
> On Monday, February 23, 2015 09:35:39 AM Johannes Berg wrote:
> > If the SKB has pages (rather than being linear, as
> > ieee80211_amsdu_to_8023s() assumes) then what Emmanuel said would
> > probably be the best approach, although it could be possible that would
> > mess up truesize accounting and lead to lower performance. Certainly
> > you'd want to do it only for suitably large packets (at least bigger
> > than 128 bytes or so)
>
> Why is it important whether it has pages? Looks like I can play with
> pointers to the linear part as well.
I don't think that will work - it would crash later trying to free that
page, no?
Oh - you mean just skb_pull() and friends? That might actually work,
yeah.
johannes
prev parent reply other threads:[~2015-02-25 7:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 10:51 [RFC] zero-copy AMSDU processing Vladimir Kondratiev
2015-02-19 11:35 ` Emmanuel Grumbach
2015-02-23 8:35 ` Johannes Berg
2015-02-25 7:07 ` Vladimir Kondratiev
2015-02-25 7:52 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424850736.2050.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=QCA_vkondrat@QCA.qualcomm.com \
--cc=egrumbach@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).