From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-wireless-owner@vger.kernel.org>
Received: from smtprelay0235.hostedemail.com ([216.40.44.235]:41261 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1752291AbbB0MgX (ORCPT
	<rfc822;linux-wireless@vger.kernel.org>);
	Fri, 27 Feb 2015 07:36:23 -0500
Message-ID: <1425040579.2690.9.camel@perches.com> (sfid-20150227_133643_542634_EAA1D9D1)
Subject: Re: [PATCH net-next] wireless: test sscanf return values
From: Joe Perches <joe@perches.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	"David S. Miller" <davem@davemloft.net>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Date: Fri, 27 Feb 2015 04:36:19 -0800
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CAF0B29@AcuExch.aculab.com>
References: <1425015791.2690.7.camel@perches.com>
	 <063D6719AE5E284EB5DD2968C1650D6D1CAF0B29@AcuExch.aculab.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org
List-ID: <linux-wireless.vger.kernel.org>

On Fri, 2015-02-27 at 10:35 +0000, David Laight wrote:
> From: Joe Perches
> > At some point, it'd be good to make sscanf use __must_check
> > so make sure the net/ uses of sscanf use the return value.
> 
> Isn't it much safer to avoid sscanf() completely and use
> a different function for converting numerics?

It's generally better to use something other than sscanf.
That doesn't mean sscanf isn't useful.