linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mac80211: drop unencrypted frames in mesh fwding
@ 2015-03-02 19:28 Bob Copeland
  2015-03-03  8:27 ` Johannes Berg
  0 siblings, 1 reply; 2+ messages in thread
From: Bob Copeland @ 2015-03-02 19:28 UTC (permalink / raw)
  To: linux-wireless, johannes; +Cc: Bob Copeland, stable

The mesh forwarding path was not checking that data
frames were protected when running an encrypted network;
add the necessary check.

Cc: stable@vger.kernel.org
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Bob Copeland <me@bobcopeland.com>
---
 net/mac80211/rx.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
index ed38d83..f0f4241 100644
--- a/net/mac80211/rx.c
+++ b/net/mac80211/rx.c
@@ -2214,6 +2214,9 @@ ieee80211_rx_h_mesh_fwding(struct ieee80211_rx_data *rx)
 	hdr = (struct ieee80211_hdr *) skb->data;
 	mesh_hdr = (struct ieee80211s_hdr *) (skb->data + hdrlen);
 
+	if (ieee80211_drop_unencrypted(rx, hdr->frame_control))
+		return RX_DROP_MONITOR;
+
 	/* frame is in RMC, don't forward */
 	if (ieee80211_is_data(hdr->frame_control) &&
 	    is_multicast_ether_addr(hdr->addr1) &&
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mac80211: drop unencrypted frames in mesh fwding
  2015-03-02 19:28 [PATCH] mac80211: drop unencrypted frames in mesh fwding Bob Copeland
@ 2015-03-03  8:27 ` Johannes Berg
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2015-03-03  8:27 UTC (permalink / raw)
  To: Bob Copeland; +Cc: linux-wireless

On Mon, 2015-03-02 at 14:28 -0500, Bob Copeland wrote:
> The mesh forwarding path was not checking that data
> frames were protected when running an encrypted network;
> add the necessary check.

Applied, thanks Bob.

johannes


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-03  8:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-02 19:28 [PATCH] mac80211: drop unencrypted frames in mesh fwding Bob Copeland
2015-03-03  8:27 ` Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).