From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <jouni@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org,
Ahmad Kholaif <akholaif@qca.qualcomm.com>
Subject: Re: [PATCH v2 1/2] cfg80211: Allow NL80211_ATTR_IFINDEX to be added to vendor events
Date: Tue, 03 Mar 2015 10:33:31 +0100 [thread overview]
Message-ID: <1425375211.2450.26.camel@sipsolutions.net> (raw)
In-Reply-To: <1424957214-6363-1-git-send-email-jouni@qca.qualcomm.com>
Both applied, thanks. I changed this code:
> + if (wdev) {
> + if (nla_put_u64(skb, NL80211_ATTR_WDEV,
> + wdev_id(wdev)))
> + goto nla_put_failure;
> + if (wdev->netdev) {
> + if (nla_put_u32(skb, NL80211_ATTR_IFINDEX,
> + wdev->netdev->ifindex))
> + goto nla_put_failure;
> + }
> + }
to just
+ if (wdev) {
+ if (nla_put_u64(skb, NL80211_ATTR_WDEV,
+ wdev_id(wdev)))
+ goto nla_put_failure;
+ if (wdev->netdev &&
+ nla_put_u32(skb, NL80211_ATTR_IFINDEX,
+ wdev->netdev->ifindex))
+ goto nla_put_failure;
+ }
though.
johannes
prev parent reply other threads:[~2015-03-03 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 13:26 [PATCH v2 1/2] cfg80211: Allow NL80211_ATTR_IFINDEX to be added to vendor events Jouni Malinen
2015-02-26 13:26 ` [PATCH v2 2/2] mac80211_hwsim: Add minimal capability for vendor command/event testing Jouni Malinen
2015-03-03 9:33 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425375211.2450.26.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=akholaif@qca.qualcomm.com \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).