From: Johannes Berg <johannes@sipsolutions.net>
To: Arik Nemtsov <arik@wizery.com>
Cc: Marek Puzyniak <marek.puzyniak@tieto.com>,
Arik Nemtsov <arikx.nemtsov@intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
ath10k@lists.infradead.org
Subject: Re: [PATCH v2 3/4] mac80211: initialize rate control earlier for tdls station
Date: Tue, 03 Mar 2015 11:06:32 +0100 [thread overview]
Message-ID: <1425377192.2450.34.camel@sipsolutions.net> (raw)
In-Reply-To: <CA+XVXffHENxD3z9dTn_LC9c7Ot0Q4FgyEoHLjdeiDTFWQGuF9w@mail.gmail.com> (sfid-20150303_110220_998365_295112A3)
On Tue, 2015-03-03 at 12:02 +0200, Arik Nemtsov wrote:
> On Tue, Mar 3, 2015 at 11:18 AM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > On Sun, 2015-03-01 at 10:21 +0200, Arik Nemtsov wrote:
> >
> >> > Arik, you have a similar patch handling only NSS. Does this one look
> >> > fine to you, and would it solve the problem your other patch solved?
> >>
> >> Well currently iwlmvm requires the NSS to be set before
> >> IEEE80211_STA_ASSOC (earlier), so this doesn't help directly.
> >> I could change mvm a bit to make it work, but I don't really see a
> >> good reason for it :)
> >>
> >> The patch looks good. Shouldn't introduce new issues (at least for iwlwifi).
> >
> > Ok, thanks. Do you think it would be possible to move all of this before
> > ASSOC?
>
> We can probably move his rate_control_rate_init() to assoc, since we have this:
And doing so would also address the nss problem, right? IIRC that's done
in the rate control init inline.
johannes
next prev parent reply other threads:[~2015-03-03 10:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 7:55 [PATCH v2 0/4] ath10k: add basic tdls support Marek Puzyniak
2015-02-25 7:55 ` [PATCH v2 1/4] ath10k: unify tx mode and dispatch Marek Puzyniak
2015-02-25 7:55 ` [PATCH v2 2/4] ath10k: make peer type configurable Marek Puzyniak
2015-02-25 7:55 ` [PATCH v2 3/4] mac80211: initialize rate control earlier for tdls station Marek Puzyniak
2015-02-27 12:50 ` Johannes Berg
2015-03-01 8:21 ` Arik Nemtsov
2015-03-03 9:18 ` Johannes Berg
2015-03-03 10:02 ` Arik Nemtsov
2015-03-03 10:06 ` Johannes Berg [this message]
2015-03-03 10:07 ` Arik Nemtsov
2015-03-04 8:16 ` Johannes Berg
2015-03-04 10:04 ` Arik Nemtsov
2015-03-04 10:38 ` Marek Puzyniak
2015-03-04 16:30 ` Arik Nemtsov
2015-03-04 18:30 ` Johannes Berg
2015-03-04 15:01 ` Kalle Valo
2015-02-25 7:55 ` [PATCH v2 4/4] ath10k: introduce basic tdls functionality Marek Puzyniak
2015-02-25 10:34 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425377192.2450.34.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arik@wizery.com \
--cc=arikx.nemtsov@intel.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marek.puzyniak@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).