From: Johannes Berg <johannes@sipsolutions.net>
To: David Miller <davem@davemloft.net>
Cc: joe@perches.com, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 13/14] wireless: Use eth_<foo>_addr instead of memset
Date: Tue, 03 Mar 2015 20:16:50 +0100 [thread overview]
Message-ID: <1425410210.2450.51.camel@sipsolutions.net> (raw)
In-Reply-To: <20150303.135737.630359651880852880.davem@davemloft.net>
On Tue, 2015-03-03 at 13:57 -0500, David Miller wrote:
> From: Johannes Berg <johannes@sipsolutions.net>
> Date: Tue, 03 Mar 2015 09:16:57 +0100
>
> > Other than that, I guess I'll apply this, but I really wish there was a
> > way to distinguish more easily which of these require alignment and
> > which don't.
>
> You can't apply "this" without the dependency patch #1.
Actually, this is the first time I see patch #1, but since it depends on
HAVE_EFFICIENT_UNALIGNED_ACCESS it doesn't really matter, the functions
already exist.
I'm not even sure that the memset in patch #1 really gets more efficient
with the u32/u16 write (and if it does, why doesn't the compiler know
it) so I guess I'm not even sure I see much point in patch #1, but that
doesn't really matter.
Anyway, I don't mind if you want to take this directly either, just let
me know.
johannes
prev parent reply other threads:[~2015-03-03 19:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 3:54 [PATCH net-next 00/14] Use eth_<foo>_addr instead of memset Joe Perches
2015-03-03 3:54 ` [PATCH net-next 04/14] wireless: " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 12/14] mac80211: " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 13/14] wireless: " Joe Perches
2015-03-03 8:16 ` Johannes Berg
2015-03-03 8:37 ` Joe Perches
2015-03-03 8:44 ` Johannes Berg
2015-03-03 8:52 ` Joe Perches
2015-03-03 9:00 ` Johannes Berg
2015-03-03 10:29 ` Joe Perches
2015-03-03 10:34 ` Johannes Berg
2015-03-03 18:57 ` David Miller
2015-03-03 19:03 ` Joe Perches
2015-03-03 19:27 ` David Miller
2015-03-03 19:16 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425410210.2450.51.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).