From: Johannes Berg <johannes@sipsolutions.net>
To: Cedric Izoard <Cedric.Izoard@ceva-dsp.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Max Stepanov <Max.Stepanov@intel.com>
Subject: Re: [PATCH v2] mac80211: Get IV len from key conf and not cipher scheme
Date: Tue, 10 Mar 2015 17:04:37 +0100 [thread overview]
Message-ID: <1426003477.1926.5.camel@sipsolutions.net> (raw)
In-Reply-To: <5842EA9CC042B141995329508713AD672105A9B0@ILMAIL1.corp.local>
I'm not sure I could follow your discussion...
> @@ -790,14 +789,17 @@ ieee80211_crypto_cs_encrypt(struct
> ieee80211_tx_data *tx,
> return TX_CONTINUE;
> }
>
> - if (unlikely(skb_headroom(skb) < cs->hdr_len &&
> - pskb_expand_head(skb, cs->hdr_len, 0, GFP_ATOMIC)))
> + if (iv_len == 0)
> + return TX_CONTINUE;
How can this be correct? You have a cipher scheme, so you want to
encrypt, but now you're not doing that? Perhaps you should drop the
frame instead?
johannes
next prev parent reply other threads:[~2015-03-10 16:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 16:02 [PATCH v2] mac80211: Get IV len from key conf and not cipher scheme Cedric Izoard
2015-03-10 16:04 ` Johannes Berg [this message]
2015-03-10 16:46 ` Cedric Izoard
2015-03-10 16:48 ` Johannes Berg
2015-03-10 17:28 ` Cedric Izoard
2015-03-10 17:33 ` Johannes Berg
2015-03-11 8:17 ` Stepanov, Max
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426003477.1926.5.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Cedric.Izoard@ceva-dsp.com \
--cc=Max.Stepanov@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).