From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org, karl.beldan@gmail.com
Subject: Re: [PATCH] mac80211: minstrel_ht: fix rounding issue in MCS duration calculation
Date: Tue, 17 Mar 2015 11:03:52 +0100 [thread overview]
Message-ID: <1426586632.1985.5.camel@sipsolutions.net> (raw)
In-Reply-To: <1426240484-37307-1-git-send-email-nbd@openwrt.org>
On Fri, 2015-03-13 at 10:54 +0100, Felix Fietkau wrote:
> On very high MCS bitrates, the calculated duration of rates that are
> next to each other can be very imprecise, due to the small packet size
> used as reference (1200 bytes).
> This is most visible in VHT80 nss=2 MCS8/9, for which minstrel shows the
> same throughput when the probability is also the same. This leads to a
> bad rate selection for such rates.
>
> Fix this issue by introducing an average A-MPDU size factor into the
> calculation.
Applied.
johannes
prev parent reply other threads:[~2015-03-17 10:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 9:54 [PATCH] mac80211: minstrel_ht: fix rounding issue in MCS duration calculation Felix Fietkau
2015-03-17 10:03 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426586632.1985.5.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=karl.beldan@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).