linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend@broadcom.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: wiphy band information
Date: Wed, 18 Mar 2015 20:18:40 +0100	[thread overview]
Message-ID: <1426706320.3001.21.camel@sipsolutions.net> (raw)
In-Reply-To: <550952B4.4050400@broadcom.com>

Hi Arend,

> Is it ok to update the wiphy band information after registration. 

I believe this will cause issues.

> In 
> brcmfmac the firmware is queried to obtain the supported channels. 
> However, it returns the channels for the current country set in 
> firmware. So after probe/registration iw shows:

> Looks fine apart from the power levels so it made me wonder if what I am 
> doing is allowed. Any opinion on this?

I think the regulatory flags will also break, since some are
pre-processed during wiphy registration.

> I assume the supported band info is intended to show what hardware can 
> do regardless of the configured country, but I have no way to pull that 
> info from the device.

I'd recommend finding (and hard-coding) a superset of all the channels
that the hardware could supported, and then dynamically setting the
disabled flag on those channels that the (current) regulatory
information cannot do.

This is something that needs to be handled throughout the code since
regulatory information can already change, but adding/removing channels
is something I'd really recommend against.

johannes


  reply	other threads:[~2015-03-18 19:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-18 10:25 wiphy band information Arend van Spriel
2015-03-18 19:18 ` Johannes Berg [this message]
2015-03-18 19:28   ` Arend van Spriel
2015-03-19  8:57     ` Arik Nemtsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426706320.3001.21.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arend@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).