From: Johannes Berg <johannes@sipsolutions.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jouni Malinen <jouni@qca.qualcomm.com>,
linux-wireless@vger.kernel.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [patch] mac80111: aes_ccm: cleanup ieee80211_aes_key_setup_encrypt()
Date: Mon, 30 Mar 2015 10:40:14 +0200 [thread overview]
Message-ID: <1427704814.26117.10.camel@sipsolutions.net> (raw)
In-Reply-To: <20150323140814.GA27609@mwanda>
On Mon, 2015-03-23 at 17:08 +0300, Dan Carpenter wrote:
> This code is written using an anti-pattern called "success handling"
> which makes it hard to read, especially if you are used to normal kernel
> style. It should instead be written as a list of directives in a row
> with branches for error handling.
Applied.
johannes
next prev parent reply other threads:[~2015-03-30 8:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 12:53 mac80111: Add BIP-GMAC-128 and BIP-GMAC-256 ciphers Dan Carpenter
2015-03-23 13:24 ` Jouni Malinen
2015-03-23 14:08 ` [patch] mac80111: aes_ccm: cleanup ieee80211_aes_key_setup_encrypt() Dan Carpenter
2015-03-24 9:32 ` Ard Biesheuvel
2015-03-30 8:40 ` Johannes Berg [this message]
2015-03-23 14:40 ` mac80111: Add BIP-GMAC-128 and BIP-GMAC-256 ciphers Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427704814.26117.10.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ard.biesheuvel@linaro.org \
--cc=dan.carpenter@oracle.com \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).