From: Johannes Berg <johannes@sipsolutions.net>
To: Ilan Peer <ilan.peer@intel.com>
Cc: linux-wireless@vger.kernel.org, mcgrof@suse.com
Subject: Re: [PATCH] cfg80211: Stop calling crda if it is not responsive
Date: Mon, 30 Mar 2015 11:11:15 +0200 [thread overview]
Message-ID: <1427706675.26117.24.camel@sipsolutions.net> (raw)
In-Reply-To: <1427609931-6113-1-git-send-email-ilan.peer@intel.com> (sfid-20150329_081902_084943_B4703242)
On Sun, 2015-03-29 at 09:18 +0300, Ilan Peer wrote:
> Patch eeca9fce1d71a4955855ceb0c3b13c1eb9db27c1 (cfg80211: Schedule
> timeout for all CRDA call) introduced a regression, where in case
> that crda is not installed (or not configured properly etc.), the
> regulatory core will needlessly continue to call it.
And print a message, which was the complaint :)
> @@ -544,6 +549,11 @@ static int call_crda(const char *alpha2)
> /* query internal regulatory database (if it exists) */
> reg_regdb_query(alpha2);
>
> + if (reg_crda_timeouts > REG_MAX_CRDA_TIMEOUTS) {
> + pr_info("Exceeded CRDA call max attempts. Not calling CRDA\n");
> + return -EINVAL;
> + }
and won't this just trade one message for another??
Or in fact, duplicate messages - 'calling crda' followed by 'exceeded'?
johannes
next prev parent reply other threads:[~2015-03-30 9:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-29 6:18 [PATCH] cfg80211: Stop calling crda if it is not responsive Ilan Peer
2015-03-30 9:11 ` Johannes Berg [this message]
2015-03-30 9:53 ` Peer, Ilan
2015-03-30 9:15 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427706675.26117.24.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ilan.peer@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox