From: Johannes Berg <johannes@sipsolutions.net>
To: Krishna Chaitanya <chaitanya.mgit@gmail.com>
Cc: miaoqing@qti.qualcomm.com, John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
ath9k-devel@qca.qualcomm.com
Subject: Re: [PATCH] mac80211: fix failed to set smps
Date: Mon, 30 Mar 2015 12:06:12 +0200 [thread overview]
Message-ID: <1427709972.26117.26.camel@sipsolutions.net> (raw)
In-Reply-To: <CABPxzYL16NbubDBLcRvtLmPSz8pMezJq627AFSVWyaj41WSxBQ@mail.gmail.com> (sfid-20150330_113447_042212_D72E76E0)
On Mon, 2015-03-30 at 15:04 +0530, Krishna Chaitanya wrote:
> On Mon, Mar 30, 2015 at 2:13 PM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > On Fri, 2015-03-27 at 13:21 +0800, miaoqing@qti.qualcomm.com wrote:
> >> From: Miaoqing Pan <miaoqing@qca.qualcomm.com>
> >>
> >> Signed-off-by: Miaoqing Pan <miaoqing@qca.qualcomm.com>
> >
> > Since you give no commit log, I can only guess what you're trying to do,
> > but I suppose you need to use "echo -n" instead of "echo".
> Johannes,
>
> We had this discussion earlier also, i still strongly feel all cases
> must work with "echo" by default, as people are not that familiar
> to use "echo -n".
Well I still strongly feel that accepting garbage on the input like this
patch will do is wrong.
johannes
prev parent reply other threads:[~2015-03-30 10:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 5:21 [PATCH] mac80211: fix failed to set smps miaoqing
2015-03-30 8:43 ` Johannes Berg
2015-03-30 9:34 ` Krishna Chaitanya
2015-03-30 10:06 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427709972.26117.26.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=chaitanya.mgit@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=miaoqing@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).