From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtprelay0150.hostedemail.com ([216.40.44.150]:49723 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753041AbbC3UF4 (ORCPT ); Mon, 30 Mar 2015 16:05:56 -0400 Message-ID: <1427745952.14276.24.camel@perches.com> (sfid-20150330_220621_481941_FC8C994C) Subject: Re: [PATCH -next] mac80211: Use #define IEEE80211_CCMP_PN_LEN and bool From: Joe Perches To: Johannes Berg Cc: "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 30 Mar 2015 13:05:52 -0700 In-Reply-To: <1427745718.26117.46.camel@sipsolutions.net> References: <1427733474.14276.11.camel@perches.com> <1427745718.26117.46.camel@sipsolutions.net> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2015-03-30 at 22:01 +0200, Johannes Berg wrote: > On Mon, 2015-03-30 at 09:37 -0700, Joe Perches wrote: > > > @@ -89,11 +90,11 @@ struct ieee80211_fragment_entry { > > unsigned int last_frag; > > unsigned int extra_len; > > struct sk_buff_head skb_list; > > - int ccmp; /* Whether fragments were encrypted with CCMP */ > > - u8 last_pn[6]; /* PN of the last fragment if CCMP was used */ > > + /* for CCMP fragments */ > > + bool ccmp; /* encrypted with CCMP */ > > + u8 last_pn[IEEE80211_CCMP_PN_LEN]; /* PN of the last fragment */ > > I took your patch as an opportunity to check into this, and it turns out > all of this logic is also going to be needed for GCMP. As a result, I'm > not going to take this patch but instead we'll fix it up for GCMP (where > using CCMP_PN_LEN would not be appropriate anyway - perhaps we need a > union or just keep '8' which is the right size for both anyway, or we'll > go to a u64 value or something) No worries. Whatever's right.