From: Joe Perches <joe@perches.com>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/4] mac80211-hwsim: remove dmesg spam about get-survey.
Date: Fri, 03 Apr 2015 14:29:02 -0700 [thread overview]
Message-ID: <1428096542.29510.11.camel@perches.com> (raw)
In-Reply-To: <1428095590-600-2-git-send-email-greearb@candelatech.com>
On Fri, 2015-04-03 at 14:13 -0700, greearb@candelatech.com wrote:
> This message just fills up dmesg and/or kernel logs and does
> not provide any useful information.
[]
> diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c
[]
> @@ -1696,7 +1696,7 @@ static int mac80211_hwsim_get_survey(
> {
> struct ieee80211_conf *conf = &hw->conf;
>
> - wiphy_debug(hw->wiphy, "%s (idx=%d)\n", __func__, idx);
> + /* wiphy_debug(hw->wiphy, "%s (idx=%d)\n", __func__, idx); */
It's better, if it's really useless, to delete this
than comment it out.
But it's not on by default anyway, so why it an issue?
next prev parent reply other threads:[~2015-04-03 21:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 21:13 [PATCH 1/4] mac80211-hwsim: notify user-space about channel change greearb
2015-04-03 21:13 ` [PATCH 2/4] mac80211-hwsim: remove dmesg spam about get-survey greearb
2015-04-03 21:29 ` Joe Perches [this message]
2015-04-03 21:38 ` Ben Greear
2015-04-03 21:13 ` [PATCH 3/4] mac80211-hwsim: Pass rate-ctrl flags and tx-power to user-space greearb
2015-04-03 21:13 ` [PATCH 4/4] mac80211-hwsim: enable better rx-status when using netlink greearb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428096542.29510.11.camel@perches.com \
--to=joe@perches.com \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).