From: Johannes Berg <johannes@sipsolutions.net>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: Move each system tracepoints to their own header
Date: Wed, 08 Apr 2015 09:44:54 +0200 [thread overview]
Message-ID: <1428479094.2809.3.camel@sipsolutions.net> (raw)
In-Reply-To: <20150407121319.72d69ec5@gandalf.local.home>
On Tue, 2015-04-07 at 12:13 -0400, Steven Rostedt wrote:
> Every tracing file must have its own TRACE_SYSTEM defined.
> The iwlwifi tracepoint header broke this and added in the middle
> of the file:
[...]
> Unfortunately, this broke new code in the ftrace infrastructure.
> Moving each of these TRACE_SYSTEMs into their own trace file with
> just one TRACE_SYSTEM per file fixes the issue.
>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> drivers/net/wireless/iwlwifi/iwl-devtrace-data.h | 79 ++++
> drivers/net/wireless/iwlwifi/iwl-devtrace-io.h | 155 ++++++++
> .../net/wireless/iwlwifi/iwl-devtrace-iwlwifi.h | 200 ++++++++++
> drivers/net/wireless/iwlwifi/iwl-devtrace-msg.h | 97 +++++
> drivers/net/wireless/iwlwifi/iwl-devtrace-ucode.h | 81 ++++
> drivers/net/wireless/iwlwifi/iwl-devtrace.h | 438 +--------------------
> 6 files changed, 618 insertions(+), 432 deletions(-)
> create mode 100644 drivers/net/wireless/iwlwifi/iwl-devtrace-data.h
> create mode 100644 drivers/net/wireless/iwlwifi/iwl-devtrace-io.h
> create mode 100644 drivers/net/wireless/iwlwifi/iwl-devtrace-iwlwifi.h
> create mode 100644 drivers/net/wireless/iwlwifi/iwl-devtrace-msg.h
> create mode 100644 drivers/net/wireless/iwlwifi/iwl-devtrace-ucode.h
Looks good to me.
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
johannes
next prev parent reply other threads:[~2015-04-08 7:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 3:13 [PATCH] mac80211: Move message tracepoints to their own header Steven Rostedt
2015-04-07 6:58 ` Johannes Berg
2015-04-07 12:55 ` Steven Rostedt
2015-04-07 13:40 ` Johannes Berg
2015-04-07 14:21 ` Steven Rostedt
2015-04-07 14:28 ` Johannes Berg
2015-04-07 16:13 ` [PATCH] iwlwifi: Move each system " Steven Rostedt
2015-04-08 7:44 ` Johannes Berg [this message]
2015-04-12 17:37 ` Emmanuel Grumbach
2015-04-13 6:22 ` Emmanuel Grumbach
2015-04-13 8:17 ` Emmanuel Grumbach
2015-04-13 15:05 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428479094.2809.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).