From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] mac80211_hwsim: notify user-space about channel change.
Date: Wed, 15 Apr 2015 11:33:20 +0200 [thread overview]
Message-ID: <1429090400.1784.2.camel@sipsolutions.net> (raw)
In-Reply-To: <552D386E.40306@candelatech.com>
On Tue, 2015-04-14 at 08:55 -0700, Ben Greear wrote:
> > True, although I'd like to see the multi-channel issue addressed better.
>
> I need a hint or two on what exactly you want changed in my patch to
> address your request, or maybe you or someone else can just address
> the issue in follow-on patches?
So right now you're basically saying to userspace "switch to channel X".
But that's not really how the more generic system works, that's more
"start using channel X (ctx=1)" / "stop using channel X (ctx=1)" /
"change channel to X (ctx=1)" and similar.
It seems to me that such an API should probably be the only API to
userspace. The non-chanctx case in hwsim could simply fake it by
starting with "start using channel X (ctx=0)" and then changing that
channel all the time.
The issue is that with your patch in this can't be addressed in
follow-on patches as it fixes the userspace API.
johannes
next prev parent reply other threads:[~2015-04-15 9:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 23:59 [RFC] mac80211_hwsim: notify user-space about channel change greearb
2015-02-23 11:49 ` Johannes Berg
2015-02-23 17:43 ` Ben Greear
2015-02-24 10:11 ` Johannes Berg
2015-02-24 14:36 ` Ben Greear
2015-02-24 14:40 ` Johannes Berg
2015-03-11 21:05 ` Ben Greear
2015-03-31 14:27 ` Johannes Berg
2015-03-31 15:56 ` Ben Greear
2015-04-14 8:13 ` Johannes Berg
2015-04-14 14:56 ` Ben Greear
2015-04-14 15:06 ` Johannes Berg
2015-04-14 15:55 ` Ben Greear
2015-04-15 9:33 ` Johannes Berg [this message]
2015-04-15 15:06 ` Ben Greear
2015-04-17 11:25 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429090400.1784.2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).