From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] mac80211_hwsim: notify user-space about channel change.
Date: Fri, 17 Apr 2015 13:25:12 +0200 [thread overview]
Message-ID: <1429269912.1885.4.camel@sipsolutions.net> (raw)
In-Reply-To: <552E7E70.5070101@candelatech.com>
On Wed, 2015-04-15 at 08:06 -0700, Ben Greear wrote:
[...]
> > The issue is that with your patch in this can't be addressed in
> > follow-on patches as it fixes the userspace API.
>
> Ok, so adding an additional 'uint16 ctx' to the channel change data,
> and providing a 'type' field that includes start-using, stop-using
> would address this problem adequately?
>
> Start-using seems it would be the same as change-channel, or do I need
> a type for that as well?
Yeah that seems reasonble. You'd need to store the ctx id in the actual
chanctx struct in hwsim I guess (and unconditionally use 0 for the
non-chanctx case)
I'm not sure we should conflate start-using and change-channel,
userspace might have to set up data structures if it really wants to
track multiple channels, so having a separate start-using might be
easier?
johannes
prev parent reply other threads:[~2015-04-17 11:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 23:59 [RFC] mac80211_hwsim: notify user-space about channel change greearb
2015-02-23 11:49 ` Johannes Berg
2015-02-23 17:43 ` Ben Greear
2015-02-24 10:11 ` Johannes Berg
2015-02-24 14:36 ` Ben Greear
2015-02-24 14:40 ` Johannes Berg
2015-03-11 21:05 ` Ben Greear
2015-03-31 14:27 ` Johannes Berg
2015-03-31 15:56 ` Ben Greear
2015-04-14 8:13 ` Johannes Berg
2015-04-14 14:56 ` Ben Greear
2015-04-14 15:06 ` Johannes Berg
2015-04-14 15:55 ` Ben Greear
2015-04-15 9:33 ` Johannes Berg
2015-04-15 15:06 ` Ben Greear
2015-04-17 11:25 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429269912.1885.4.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).