Re: [PATCH] cfg80211: Allow GO concurrent relaxation after BSS disconnetion

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2015-03-30 at 16:08 +0300, Emmanuel Grumbach wrote:
> From: Avraham Stern <avraham.stern@intel.com>
> 
> If P2P GO was allowed on a channel because of the GO concurrent
> relaxation and additional station interface associated to an AP on
> the same channel or the same UNII band, and the station interface
> disconnected from the AP, allow the P2P GO to stay on that channel
> unless the channel is marked as indoor only and the device is not
> operating in an indoor environment.

I'm not really sure what to do with this - this neither explains why
this is needed nor why it's actually allowed to do it.

> +               if (wdev->iftype == NL80211_IFTYPE_STATION &&
> +                   netif_running(wdev->netdev) && wdev->current_bss)

having a current_bss implies running

> +               if (wdev->iftype == NL80211_IFTYPE_P2P_GO &&
> wdev->netdev &&
> +                   netif_running(wdev->netdev) &&
> wdev->beacon_interval &&
> +                   !(chan->flags & IEEE80211_CHAN_INDOOR_ONLY))
> +                       other_chan = wdev->chandef.chan;

that "wdev->netdev" check is also useless, iftype==P2P_GO must have a
netdev.
netif_running() is probably also useless since wdev->beacon_interval
implies it.

This patch also doesn't really do exactly what you said it does - it
doesn't just allow that GO to be running but it also allows more to be
started up there... Not sure if that's desired, but it should be
documented (again, with the reasons for it)

johannes