From: Joe Perches <joe@perches.com>
To: Okash Khawaja <okash.khawaja@gmail.com>
Cc: kvalo@codeaurora.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] adm8211: fix checkpatch error for trailing statements on next line
Date: Mon, 04 May 2015 23:44:58 -0700 [thread overview]
Message-ID: <1430808298.7191.1.camel@perches.com> (raw)
In-Reply-To: <20150505060150.GA2548@bytefire-computer>
On Tue, 2015-05-05 at 07:01 +0100, Okash Khawaja wrote:
> This patch fixes the checkpatch.pl error:
Please fix the space/tab use too.
Your email client seems to have converted all the tabs
to spaces.
default should use the same indent as the case statements
> diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c
[]
> @@ -1098,14 +1098,18 @@ static void adm8211_hw_init(struct ieee80211_hw *dev)
> pci_read_config_byte(priv->pdev, PCI_CACHE_LINE_SIZE, &cline);
>
> switch (cline) {
> - case 0x8: reg |= (0x1 << 14);
> - break;
> - case 0x16: reg |= (0x2 << 14);
> - break;
> - case 0x32: reg |= (0x3 << 14);
> - break;
> - default: reg |= (0x0 << 14);
> - break;
> + case 0x8:
> + reg |= (0x1 << 14);
> + break;
> + case 0x16:
> + reg |= (0x2 << 14);
> + break;
> + case 0x32:
> + reg |= (0x3 << 14);
> + break;
> + default:
> + reg |= (0x0 << 14);
> + break;
> }
> }
>
next prev parent reply other threads:[~2015-05-05 6:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 6:01 [PATCH v3] adm8211: fix checkpatch error for trailing statements on next line Okash Khawaja
2015-05-05 6:44 ` Joe Perches [this message]
2015-05-05 11:45 ` Okash Khawaja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430808298.7191.1.camel@perches.com \
--to=joe@perches.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=okash.khawaja@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).