From: Johannes Berg <johannes@sipsolutions.net>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: IBSS, clear fast_sta when update rates
Date: Mon, 11 May 2015 11:53:27 +0200 [thread overview]
Message-ID: <1431338007.1964.16.camel@sipsolutions.net> (raw)
In-Reply-To: <1431337921.1964.15.camel@sipsolutions.net> (sfid-20150511_115210_912154_EBE83A3A)
On Mon, 2015-05-11 at 11:52 +0200, Johannes Berg wrote:
> On Mon, 2015-05-11 at 11:39 +0200, Janusz Dziedzic wrote:
> > This is required to handle sta.wme correctly
> > after update rates (eg. when using HT/VHT) when
> > driver using IEEE80211_HW_SUPPORT_FAST_XMIT.
>
> Wouldn't you want to check, so it can be re-assigned?
i.e. something like
diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c
index bfef1b215050..7e62183525aa 100644
--- a/net/mac80211/ibss.c
+++ b/net/mac80211/ibss.c
@@ -1031,8 +1031,11 @@ static void ieee80211_update_sta_info(struct ieee80211_sub_if_data *sdata,
}
}
- if (sta && elems->wmm_info && local->hw.queues >= IEEE80211_NUM_ACS)
+ if (sta && !sta->sta.wme && elems->wmm_info &&
+ local->hw.queues >= IEEE80211_NUM_ACS) {
sta->sta.wme = true;
+ ieee80211_check_fast_xmit(sta);
+ }
if (sta && elems->ht_operation && elems->ht_cap_elem &&
sdata->u.ibss.chandef.width != NL80211_CHAN_WIDTH_20_NOHT &&
johannes
next prev parent reply other threads:[~2015-05-11 9:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 9:39 [PATCH] mac80211: IBSS, clear fast_sta when update rates Janusz Dziedzic
2015-05-11 9:52 ` Johannes Berg
2015-05-11 9:53 ` Johannes Berg [this message]
2015-05-11 11:52 ` Janusz Dziedzic
2015-05-11 12:01 ` Johannes Berg
2015-05-12 4:56 ` Janusz Dziedzic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431338007.1964.16.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=janusz.dziedzic@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).