From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] mac80211: prevent possible crypto tx tailroom corruption
Date: Thu, 21 May 2015 10:30:58 +0200 [thread overview]
Message-ID: <1432197058.2343.7.camel@sipsolutions.net> (raw)
In-Reply-To: <CA+BoTQkpjDodKNdSvj2ZdKemXU_2E39MVGZPob8+jkjBGESEfg@mail.gmail.com> (sfid-20150521_101657_739944_260917A1)
On Thu, 2015-05-21 at 10:16 +0200, Michal Kazior wrote:
> >> rtnl_lock();
> >> + list_for_each_entry(sdata, &local->interfaces, list)
> >> + cancel_delayed_work_sync(&sdata->dec_tailroom_needed_wk);
> >
> > Would it make sense to just flush the work here? That way we don't have
> > to do all the other things.
>
> Hmm.. dec_tailroom_needed_wk is queued on system workqueue now so
> there's no feasible way of flushing it (restart_work is on a system
> workqueue as well). It'd need to be moved to local->workqueue. I guess
> that would work too.
flush_work()?
johannes
next prev parent reply other threads:[~2015-05-21 8:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 13:05 [PATCH] mac80211: fix AP_VLAN crypto tailroom calculation Michal Kazior
2015-05-11 13:11 ` Johannes Berg
2015-05-11 13:33 ` Michal Kazior
2015-05-13 9:16 ` [PATCH v2 1/2] " Michal Kazior
2015-05-13 9:16 ` [PATCH v2 2/2] mac80211: prevent possible crypto tx tailroom corruption Michal Kazior
2015-05-20 13:14 ` Johannes Berg
2015-05-21 8:16 ` Michal Kazior
2015-05-21 8:30 ` Johannes Berg [this message]
2015-05-21 8:44 ` Michal Kazior
2015-05-22 8:22 ` [PATCH v3] " Michal Kazior
2015-05-29 11:05 ` Johannes Berg
2015-05-20 13:12 ` [PATCH v2 1/2] mac80211: fix AP_VLAN crypto tailroom calculation Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432197058.2343.7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).