From: Joe Perches <joe@perches.com>
To: rahul.jain@samsung.com
Cc: "johannes.berg@intel.com" <johannes.berg@intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] Reordering for better readability and consistency [EDT]
Date: Mon, 25 May 2015 01:14:30 -0700 [thread overview]
Message-ID: <1432541670.2846.48.camel@perches.com> (raw)
In-Reply-To: <255092351.26861432539449201.JavaMail.weblogic@epmlwas02a>
On Mon, 2015-05-25 at 07:37 +0000, Rahul Jain wrote:
> diff --git a/net/wireless/util.c b/net/wireless/util.c
[]
> @@ -1340,10 +1340,7 @@ bool ieee80211_operating_class_to_band(u8 operating_class,
> case 128 ... 130:
> *band = IEEE80211_BAND_5GHZ;
> return true;
> - case 81:
> - case 82:
> - case 83:
> - case 84:
> + case 81 ... 84:
> *band = IEEE80211_BAND_2GHZ;
> return true;
> case 180:
While I don't find this particularly more readable,
I would probably find it more readable in numeric
ascending order and the case moved above BAND_5GHZ.
Also, this function seems to be used only once in
net/mac80211/spectmgmt.c Maybe it should be static
in that file and not EXPORT_SYMBOL.
prev parent reply other threads:[~2015-05-25 8:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 7:37 [PATCH] Reordering for better readability and consistency [EDT] Rahul Jain
2015-05-25 7:59 ` Rafał Miłecki
2015-05-25 8:14 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432541670.2846.48.camel@perches.com \
--to=joe@perches.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rahul.jain@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).