From: Johannes Berg <johannes@sipsolutions.net>
To: Amitkumar Karwar <akarwar@marvell.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Cathy Luo <cluo@marvell.com>, Avinash Patil <patila@marvell.com>
Subject: Re: [PATCH 5/6] mwifiex: use generic name 'device dump'
Date: Wed, 27 May 2015 09:24:26 +0200 [thread overview]
Message-ID: <1432711466.2159.0.camel@sipsolutions.net> (raw)
In-Reply-To: <f92fc66de96b485dba99642987703334@SC-EXCH02.marvell.com>
On Wed, 2015-05-27 at 07:04 +0000, Amitkumar Karwar wrote:
> Thanks for your review. We are dumping driver data as well along with
> firmware state. Hence we thought of renaming 'fw_dump' with
> 'device_dump'.
[...]
> Debugfs file name is changed because 'device_dump' will now take care
> of dumping both driver data and firmware state.
Ok, great. Just wanted to make sure you weren't pointlessly renaming it
because of the framework name :)
> Currently we are triggering the dump operation in our command timeout
> handler as well. This would help us debug possible firmware bug
> causing timeout.
Cool, yeah, it's helping us a lot for sure.
johannes
next prev parent reply other threads:[~2015-05-27 7:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 13:34 [PATCH 0/6] mwifiex: device dump enhancements Amitkumar Karwar
2015-05-26 13:34 ` [PATCH 1/6] mwifiex: fix SDIO firmware dump problem Amitkumar Karwar
2015-06-02 20:18 ` [1/6] " Kalle Valo
2015-05-26 13:34 ` [PATCH 2/6] mwifiex: fix a possible double free issue Amitkumar Karwar
2015-05-26 13:34 ` [PATCH 3/6] mwifiex: dump driver information for PCIe interface Amitkumar Karwar
2015-05-26 13:34 ` [PATCH 4/6] mwifiex: minor changes in debug messages Amitkumar Karwar
2015-05-26 13:34 ` [PATCH 5/6] mwifiex: use generic name 'device dump' Amitkumar Karwar
2015-05-26 14:30 ` Johannes Berg
2015-05-27 7:04 ` Amitkumar Karwar
2015-05-27 7:24 ` Johannes Berg [this message]
2015-05-26 13:34 ` [PATCH 6/6] mwifiex: device dump support via devcoredump framework Amitkumar Karwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432711466.2159.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=akarwar@marvell.com \
--cc=cluo@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=patila@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).