From: Johannes Berg <johannes@sipsolutions.net>
To: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 1/2] nl80211: Add support to configure low ack threshold
Date: Thu, 28 May 2015 15:19:00 +0200 [thread overview]
Message-ID: <1432819140.2459.6.camel@sipsolutions.net> (raw)
In-Reply-To: <1432794355-3639-1-git-send-email-rmanohar@qti.qualcomm.com>
On Thu, 2015-05-28 at 11:55 +0530, Rajkumar Manoharan wrote:
> @@ -837,6 +839,7 @@ struct station_parameters {
> u8 supported_oper_classes_len;
> u8 opmode_notif;
> bool opmode_notif_used;
> + u16 low_ack_threshold;
This cannot work, it leaves no way to detect "no change"; you need to
add that, document it and also implement it in the mac80211 patch.
johannes
prev parent reply other threads:[~2015-05-28 13:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 6:25 [PATCH v2 1/2] nl80211: Add support to configure low ack threshold Rajkumar Manoharan
2015-05-28 6:25 ` [PATCH v2 2/2] mac80211: store low ack threshold in bss config Rajkumar Manoharan
2015-05-28 13:19 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432819140.2459.6.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).