From: Joe Perches <joe@perches.com>
To: Avinash Patil <patila@marvell.com>
Cc: linux-wireless@vger.kernel.org, akarwar@marvell.com,
cluo@marvell.com, huxm@marvell.com
Subject: Re: [PATCH 01/17] mwifiex: verbose logging for association failure messages
Date: Thu, 28 May 2015 11:27:34 -0700 [thread overview]
Message-ID: <1432837654.1556.2.camel@perches.com> (raw)
In-Reply-To: <1432817889-26250-2-git-send-email-patila@marvell.com>
On Thu, 2015-05-28 at 18:27 +0530, Avinash Patil wrote:
> This patch adds more logging support for association failure -
> reason and states.
[]
> diff --git a/drivers/net/wireless/mwifiex/fw.h b/drivers/net/wireless/mwifiex/fw.h
[]
> @@ -419,8 +419,12 @@ enum P2P_MODES {
> #define HS_CFG_COND_MAC_EVENT 0x00000004
> #define HS_CFG_COND_MULTICAST_DATA 0x00000008
>
> -#define MWIFIEX_TIMEOUT_FOR_AP_RESP 0xfffc
> -#define MWIFIEX_STATUS_CODE_AUTH_TIMEOUT 2
> +#define ASSOC_ERR_AUTH_ERR_STA_FAILURE 0xFFFB
> +#define ASSOC_ERR_ASSOC_ERR_TIMEOUT 0xFFFC
> +#define ASSOC_ERR_ASSOC_ERR_AUTH_REFUSED 0xFFFD
Is there really value in duplicating ASSOC_ERR_
ASSOC_ERR_ASSOC_ERR_<foo>
next prev parent reply other threads:[~2015-05-28 18:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1432817889-26250-1-git-send-email-patila@marvell.com>
2015-05-28 12:57 ` [PATCH 01/17] mwifiex: verbose logging for association failure messages Avinash Patil
2015-05-28 18:27 ` Joe Perches [this message]
2015-05-29 9:27 ` Avinash Patil
2015-05-28 12:57 ` [PATCH 02/17] mwifiex: correct bss_type assignment Avinash Patil
2015-05-28 18:28 [PATCH 00/17] mwifiex patches Avinash Patil
2015-05-28 18:28 ` [PATCH 01/17] mwifiex: verbose logging for association failure messages Avinash Patil
[not found] <1432817766-26090-1-git-send-email-patila@marvell.com>
2015-05-28 12:55 ` Avinash Patil
[not found] <1432817552-25866-1-git-send-email-patila@marvell.com>
2015-05-28 12:52 ` Avinash Patil
[not found] <1432817450-25619-1-git-send-email-patila@marvell.com>
2015-05-28 12:50 ` Avinash Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432837654.1556.2.camel@perches.com \
--to=joe@perches.com \
--cc=akarwar@marvell.com \
--cc=cluo@marvell.com \
--cc=huxm@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=patila@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).