From: Johannes Berg <johannes@sipsolutions.net>
To: Chaitanya T K <chaitanya.mgit@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: Fix power save state stuck in ACTIVE caused by race between suspend and Tx packet.
Date: Mon, 01 Jun 2015 16:45:02 +0200 [thread overview]
Message-ID: <1433169902.3505.14.camel@sipsolutions.net> (raw)
In-Reply-To: <1433067731-20114-1-git-send-email-chaitanya.mgit@gmail.com> (sfid-20150531_122408_973977_DB036358)
On Sun, 2015-05-31 at 15:52 +0530, Chaitanya T K wrote:
> From: Chaitanya T K <chaitanya.mgit@gmail.com>
>
> If we receive suspend after TX path has executed
> dynamic ps disable work, the driver will be in
> ACTIVE state during suspend and even after it
> resumes.
>
> As before suspend all data packets are flushed
> it is safe to put the driver in to sleep for
> optimal power during suspend or up on resume.
Now that I've actually looked into the code, the patch makes some sense.
However, please rewrite the commit log and the comment in the code.
johannes
next prev parent reply other threads:[~2015-06-01 14:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-31 10:22 [PATCH] mac80211: Fix power save state stuck in ACTIVE caused by race between suspend and Tx packet Chaitanya T K
2015-05-31 10:23 ` Krishna Chaitanya
2015-06-01 14:45 ` Johannes Berg [this message]
[not found] <1431602181-17700-1-git-send-email-chaitanya.mgit@gmail.com>
2015-05-19 7:31 ` Johannes Berg
2015-05-19 8:23 ` Krishna Chaitanya
2015-05-20 13:41 ` Johannes Berg
2015-05-20 13:57 ` Krishna Chaitanya
[not found] <1431939609-7261-1-git-send-email-chaitanya.mgit@gmail.com>
2015-05-18 9:05 ` Johannes Berg
2015-05-18 9:19 ` Krishna Chaitanya
2015-05-18 9:24 ` Johannes Berg
2015-05-18 9:28 ` Krishna Chaitanya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433169902.3505.14.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=chaitanya.mgit@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).