From: Johannes Berg <johannes@sipsolutions.net>
To: David Liu <cfliu.tw@gmail.com>
Cc: linux-wireless@vger.kernel.org, kvalo@qca.qualcomm.com
Subject: Re: [PATCH] mac80211: support IEEE80211_KEY_FLAG_RESERVE_TAILROOM for CCMP and TKIP.
Date: Mon, 01 Jun 2015 22:34:20 +0200 [thread overview]
Message-ID: <1433190860.3505.16.camel@sipsolutions.net> (raw)
In-Reply-To: <1433187498-15124-1-git-send-email-cfliu.tw@gmail.com> (sfid-20150601_213859_576975_56A22551)
On Mon, 2015-06-01 at 12:38 -0700, David Liu wrote:
> The change reserves neccessary tailroom in CCMP and TKIP if required by
> drivers that sets IEEE80211_KEY_FLAG_RESERVE_TAILROOM. For example,
> ath10k HW engine in raw Tx/Rx encap mode requires SW reserve MIC/ICV space.
I don't think this makes all that much sense. The flag is already
honoured today to actually leave enough tailroom in the SKB, and the
remainder of the code can very easily be done in the driver (in fact, if
you have a half-decent DMA engine, it's far more efficient to *not* set
this flag!)
You're also breaking other drivers with your change. Just do it in the
driver.
johannes
next prev parent reply other threads:[~2015-06-01 20:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 19:38 [PATCH] mac80211: support IEEE80211_KEY_FLAG_RESERVE_TAILROOM for CCMP and TKIP David Liu
2015-06-01 20:34 ` Johannes Berg [this message]
2015-06-01 23:48 ` Liu CF/TW
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433190860.3505.16.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=cfliu.tw@gmail.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).