From: Johannes Berg <johannes@sipsolutions.net>
To: Krishna Chaitanya <chaitanya.mgit@gmail.com>
Cc: Felix Fietkau <nbd@openwrt.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] minstrel_ht: Use RTS_CTS when STA is in DYNAMIC SMPS mode for frames sent using Nss>1.
Date: Mon, 01 Jun 2015 22:36:49 +0200 [thread overview]
Message-ID: <1433191009.3505.18.camel@sipsolutions.net> (raw)
In-Reply-To: <CABPxzYLW955-jJHKHYT+P0U8RM=GWajpCYDa8L-XtjCN71U0kw@mail.gmail.com> (sfid-20150601_201947_721441_892EB760)
On Mon, 2015-06-01 at 23:49 +0530, Krishna Chaitanya wrote:
> On Thu, Jan 30, 2014 at 11:48 PM, Krishna Chaitanya
> <chaitanya.mgit@gmail.com> wrote:
> > On Thu, Jan 23, 2014 at 2:57 AM, Johannes Berg
> > <johannes@sipsolutions.net> wrote:
> >>
> >> On Wed, 2014-01-22 at 12:27 +0530, Chaitanya T K wrote:
> >>
> >> > + if (sta->smps_mode == IEEE80211_SMPS_DYNAMIC &&
> >> > + minstrel_mcs_groups[i].streams > 1) {
> >> > + mi->tx_flags |= IEEE80211_TX_RC_USE_RTS_CTS;
> >> > + } else if (sta->smps_mode == IEEE80211_SMPS_STATIC &&
> >> > + minstrel_mcs_groups[i].streams > 1) {
> >>
> >> Your indentation is off inside the if statements. I'll have to wait for
> >> nbd to review the patch itself, I guess.
> >>
> > Felix,
> >
> > Any comments other than the indentation? If no, will send in the
> > v2 with indentation fixed.
>
> Was checking my old submissions. This was marked as "Not Applicable" in
> patchwork.
>
> Felix/Johannes,
>
> Can you please explain to me the meaning of the status "Not Applicable"?
This patch is *ancient*, before we actually used patchwork properly ...
johannes
next prev parent reply other threads:[~2015-06-01 20:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 6:57 [PATCH] minstrel_ht: Use RTS_CTS when STA is in DYNAMIC SMPS mode for frames sent using Nss>1 Chaitanya T K
2014-01-22 21:27 ` Johannes Berg
2014-01-22 21:53 ` Krishna Chaitanya
2014-01-30 18:18 ` Krishna Chaitanya
2015-06-01 18:19 ` Krishna Chaitanya
2015-06-01 20:36 ` Johannes Berg [this message]
2015-06-01 21:33 ` Krishna Chaitanya
2015-06-01 21:40 ` Johannes Berg
2015-06-02 18:29 ` Krishna Chaitanya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433191009.3505.18.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=chaitanya.mgit@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).