From: Johannes Berg <johannes@sipsolutions.net>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
gregory.greenman@intel.com
Subject: Re: [RFC] mac80211: convert HW flags to unsigned long bitmap
Date: Wed, 03 Jun 2015 09:02:51 +0200 [thread overview]
Message-ID: <1433314971.2274.1.camel@sipsolutions.net> (raw)
In-Reply-To: <CAGRGNgV_4axC8Cq5AYkd7RQdJOnrT_9L85qisrrZnKYHyUEczQ@mail.gmail.com> (sfid-20150603_025745_650833_28A1FD99)
On Wed, 2015-06-03 at 10:57 +1000, Julian Calaby wrote:
> Why not add a ieee80211_hw_clear() function? Yes, it'd only be used in
> 3 places, but it'd look neater.
Well, this was actually intentional.
Drivers are not *supposed* to be doing this, the hardware flags are
supposed to be constant hardware description flags. The three drivers
clearing this specific but currently work OK due to the way this
particular flag is treated, but that wouldn't necessarily the case for
all of the flags; adding a _clear() function would seem to imply that
it's OK to do this, when it's really not.
johannes
next prev parent reply other threads:[~2015-06-03 7:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 19:39 [RFC] mac80211: convert HW flags to unsigned long bitmap Johannes Berg
2015-06-03 0:57 ` Julian Calaby
2015-06-03 7:02 ` Johannes Berg [this message]
2015-06-03 7:16 ` Julian Calaby
2015-06-03 6:35 ` Joe Perches
2015-06-03 7:04 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433314971.2274.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=gregory.greenman@intel.com \
--cc=julian.calaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).