From: Johannes Berg <johannes@sipsolutions.net>
To: Wojciech Dubowik <Wojciech.Dubowik@neratec.com>
Cc: linux-wireless@vger.kernel.org, julian.calaby@gmail.com
Subject: Re: [PATCH v2] mac80211: Fix double locking on CSA counter update
Date: Tue, 09 Jun 2015 21:46:18 +0200 [thread overview]
Message-ID: <1433879178.1892.14.camel@sipsolutions.net> (raw)
In-Reply-To: <1433170291-28665-1-git-send-email-Wojciech.Dubowik@neratec.com> (sfid-20150601_165150_599042_C9CB69CD)
On Mon, 2015-06-01 at 16:51 +0200, Wojciech Dubowik wrote:
> We call rcu locked ieee80211_csa_update_counter from already locked
> section. Fix it by splitting ieee80211_csa_update_counter into
> locked and unlocked variants and use the latter in rcu locked section.
The subject of this patch implies there's a bug ("double locking", which
I'd interpret as "nested locking") and that there's something to fix.
At best, this is an optimisation, can you please label it as such?
johannes
prev parent reply other threads:[~2015-06-09 19:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 14:51 [PATCH v2] mac80211: Fix double locking on CSA counter update Wojciech Dubowik
2015-06-09 19:46 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433879178.1892.14.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Wojciech.Dubowik@neratec.com \
--cc=julian.calaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).