From: Johannes Berg <johannes@sipsolutions.net>
To: Krishna Chaitanya <chaitanya.mgit@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH V2] mac80211: Fix power save state stuck in ACTIVE caused by race between suspend and Tx packet.
Date: Tue, 09 Jun 2015 22:10:29 +0200 [thread overview]
Message-ID: <1433880629.1892.24.camel@sipsolutions.net> (raw)
In-Reply-To: <CABPxzYLMiX1chbNxUd4gfK2HeKkXxHEw1rjf+5on4mskxce1Gg@mail.gmail.com> (sfid-20150601_233225_467260_D87DD2BF)
On Tue, 2015-06-02 at 03:02 +0530, Krishna Chaitanya wrote:
> > This isn't what your patch is actually doing though. You need to mention
> > WoWLAN at the very least in your commit log;
> Yes, WoWLAN is enabled in our testing. Without wowlan the connection
> will not be intact. So i assumed the check "is_associated" would
> imply wowlan.
I meant the commit log.
If I read your commit log without the patch, it doesn't make sense at
all since regular suspend/resume will turn off the device anyway. You
really need to mention
a) the fact that wowlan is used, and
b) the fact that you care about powersave state *while in wowlan*
johannes
next prev parent reply other threads:[~2015-06-09 20:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 17:14 [PATCH V2] mac80211: Fix power save state stuck in ACTIVE caused by race between suspend and Tx packet Chaitanya T K
2015-06-01 20:36 ` Johannes Berg
2015-06-01 21:32 ` Krishna Chaitanya
2015-06-09 20:10 ` Johannes Berg [this message]
2015-06-09 20:30 ` Krishna Chaitanya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433880629.1892.24.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=chaitanya.mgit@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).