From: greearb@candelatech.com
To: linux-wireless@vger.kernel.org
Cc: johannes@sipsolutions.net, Ben Greear <greearb@candelatech.com>
Subject: [PATCH] iw: Use ifname if available, print new/del/stop events.
Date: Wed, 10 Jun 2015 18:17:55 -0400 [thread overview]
Message-ID: <1433974675-19225-1-git-send-email-greearb@candelatech.com> (raw)
From: Ben Greear <greearb@candelatech.com>
If the kernel sends the IFNAME in the netlink message, then
use it to save the call to map ifindex to name (and
potentially fix races, especially when kernel is
busy deleting an interface.
Signed-off-by: Ben Greear <greearb@candelatech.com>
---
event.c | 22 +++++++++++++++++++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a/event.c b/event.c
index 929854b..b87a076 100644
--- a/event.c
+++ b/event.c
@@ -317,15 +317,22 @@ static int print_event(struct nl_msg *msg, void *arg)
nla_parse(tb, NL80211_ATTR_MAX, genlmsg_attrdata(gnlh, 0),
genlmsg_attrlen(gnlh, 0), NULL);
- if (tb[NL80211_ATTR_IFINDEX] && tb[NL80211_ATTR_WIPHY]) {
+ ifname[0] = 0;
+ if (tb[NL80211_ATTR_IFNAME]) {
+ memset(ifname, 0, sizeof(ifname));
+ strncpy(ifname, nla_data(tb[NL80211_ATTR_IFNAME]), IFNAMSIZ);
+ }
+ else if (tb[NL80211_ATTR_IFINDEX]) {
if_indextoname(nla_get_u32(tb[NL80211_ATTR_IFINDEX]), ifname);
+ }
+
+ if (ifname[0] && tb[NL80211_ATTR_WIPHY]) {
printf("%s (phy #%d): ", ifname, nla_get_u32(tb[NL80211_ATTR_WIPHY]));
} else if (tb[NL80211_ATTR_WDEV] && tb[NL80211_ATTR_WIPHY]) {
printf("wdev 0x%llx (phy #%d): ",
(unsigned long long)nla_get_u64(tb[NL80211_ATTR_WDEV]),
nla_get_u32(tb[NL80211_ATTR_WIPHY]));
- } else if (tb[NL80211_ATTR_IFINDEX]) {
- if_indextoname(nla_get_u32(tb[NL80211_ATTR_IFINDEX]), ifname);
+ } else if (ifname[0]) {
printf("%s: ", ifname);
} else if (tb[NL80211_ATTR_WDEV]) {
printf("wdev 0x%llx: ", (unsigned long long)nla_get_u64(tb[NL80211_ATTR_WDEV]));
@@ -599,6 +606,15 @@ static int print_event(struct nl_msg *msg, void *arg)
}
printf("\n");
break;
+ case NL80211_CMD_STOP_AP:
+ printf("stop AP\n");
+ break;
+ case NL80211_CMD_NEW_INTERFACE:
+ printf("new interface\n");
+ break;
+ case NL80211_CMD_DEL_INTERFACE:
+ printf("delete interface\n");
+ break;
default:
printf("unknown event %d (%s)\n",
gnlh->cmd, command_name(gnlh->cmd));
--
1.9.3
next reply other threads:[~2015-06-10 22:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 22:17 greearb [this message]
2015-06-17 9:14 ` [PATCH] iw: Use ifname if available, print new/del/stop events Johannes Berg
2015-06-17 13:45 ` Ben Greear
2015-07-17 8:55 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433974675-19225-1-git-send-email-greearb@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).