From: Johannes Berg <johannes@sipsolutions.net>
To: agreen@cococorp.com
Cc: linux-wireless@vger.kernel.org, Jesse Jones <jjones@cococorp.com>
Subject: Re: [PATCH] mac80211: Check SN for deactivated mpaths
Date: Wed, 17 Jun 2015 11:00:46 +0200 [thread overview]
Message-ID: <1434531646.1884.18.camel@sipsolutions.net> (raw)
In-Reply-To: <557B5F4F.1060703@cococorp.com> (sfid-20150613_003822_322805_8822167A)
On Fri, 2015-06-12 at 15:38 -0700, Alexis Green wrote:
> From: Jesse Jones <jjones@cococorp.com>
>
> When processing a PREQ or PREP it's critical to use the incoming SN. If
> that is improperly done routing loops and other types of badness can
> happen. But the code was always processing path messages for deactivated
> paths. This path fixes that so that if we have a valid SN then we use it
> to verify that it is a message we can accept. For reference the relevant
> section of the standard is 13.10.8.4 which doesn't address the deactivated
> path case at all.
>
> I also included a special case for when our peer reboots or restarts
> networking. This is an important case because without it there can be a
> very long delay before we accept path messages from that peer. It's also a
> simple case and intimately associated with processing messages for
> deactivated paths so I used one patch instead of two.
Applied.
johannes
prev parent reply other threads:[~2015-06-17 9:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 22:38 [PATCH] mac80211: Check SN for deactivated mpaths Alexis Green
2015-06-17 9:00 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434531646.1884.18.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=agreen@cococorp.com \
--cc=jjones@cococorp.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).