From: Johannes Berg <johannes@sipsolutions.net>
To: Bob Copeland <me@bobcopeland.com>
Cc: linux-wireless@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] mac80211: enable assoc check for mesh interfaces
Date: Wed, 17 Jun 2015 11:01:31 +0200 [thread overview]
Message-ID: <1434531691.1884.19.camel@sipsolutions.net> (raw)
In-Reply-To: <1434204991-9579-1-git-send-email-me@bobcopeland.com> (sfid-20150613_161648_437877_9DE6CF3A)
On Sat, 2015-06-13 at 10:16 -0400, Bob Copeland wrote:
> We already set a station to be associated when peering completes, both
> in user space and in the kernel. Thus we should always have an
> associated sta before sending data frames to that station.
>
> Failure to check assoc state can cause crashes in the lower-level driver
> due to transmitting unicast data frames before driver sta structures
> (e.g. ampdu state in ath9k) are initialized. This occurred when
> forwarding in the presence of fixed mesh paths: frames were transmitted
> to stations with whom we hadn't yet completed peering.
Applied.
johannes
prev parent reply other threads:[~2015-06-17 9:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-13 14:16 [PATCH] mac80211: enable assoc check for mesh interfaces Bob Copeland
2015-06-17 9:01 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434531691.1884.19.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).