linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wireless:  Add ifname to STOP_AP event.
Date: Wed, 17 Jun 2015 11:14:13 +0200	[thread overview]
Message-ID: <1434532453.1884.26.camel@sipsolutions.net> (raw)
In-Reply-To: <1433974625-327-1-git-send-email-greearb@candelatech.com>

On Wed, 2015-06-10 at 15:17 -0700, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
> 
> In case user-space wants to know the name of the
> device, this will save a name lookup by index, and
> in case where kernel manages to fully delete the
> interface before user-space can determine the name,
> this will ensure user-space has proper name.

None of this reasoning is specific to the STOP_AP event, and I'd hate us
adding it one by one...

I still think there isn't all that much reason to have it (if userspace
really needs the names so badly it could also subscribe to the rtnetlink
and keep a table of index/names!), but I could get behind a refactoring
of all these places (I count at least 10 events that include the wdev
id) to combine the four lines in the patch below into a single helper.

johannes


      reply	other threads:[~2015-06-17  9:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-10 22:17 [PATCH] wireless: Add ifname to STOP_AP event greearb
2015-06-17  9:14 ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434532453.1884.26.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).