linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@openwrt.org>
Cc: Sujith Manoharan <sujith@msujith.org>,
	Janusz Dziedzic <janusz.dziedzic@tieto.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [RFCv2] ath9k: make rxfilter per HW
Date: Wed, 17 Jun 2015 11:58:25 +0200	[thread overview]
Message-ID: <1434535105.1884.36.camel@sipsolutions.net> (raw)
In-Reply-To: <55814109.7030100@openwrt.org> (sfid-20150617_114251_641123_637D2FB2)

On Wed, 2015-06-17 at 11:42 +0200, Felix Fietkau wrote:
> On 2015-06-17 11:39, Sujith Manoharan wrote:
> > Janusz Dziedzic wrote:
> >> This is what I have with use_chanctx=1
> >> Jun 17 06:57:54 dell6430 kernel: [53297.753256] xxx ath_calcrxfilter
> >> filter: 0x207
> >> 
> >> 0x000000080 is for probe_req
> > 
> > Ok, so the probe_req filter is set before actually initiating
> > RoC - this appears to be the current design in wpa_s.
> > 
> > I am not sure if using a global filter that disregards
> > the opmode of a context is the right approach, though...
> The filter is intended to be global in the mac80211 API.
> Treating it as per channel-context inside the driver is a bug.

We have a patch somewhere in our pipeline (not ready/complete yet) that
will change it to be per interface. From there, you could derive per
channel context too if you wish.

johannes


      parent reply	other threads:[~2015-06-17  9:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17  5:46 [RFCv2] ath9k: make rxfilter per HW Janusz Dziedzic
2015-06-17  7:21 ` Felix Fietkau
2015-06-17  8:20 ` Sujith Manoharan
2015-06-17  8:28   ` Felix Fietkau
2015-06-17  9:00     ` Sujith Manoharan
2015-06-17  9:03       ` Janusz Dziedzic
2015-06-17  9:39         ` Sujith Manoharan
2015-06-17  9:42           ` Felix Fietkau
2015-06-17  9:52             ` Sujith Manoharan
2015-06-17  9:58             ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434535105.1884.36.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=janusz.dziedzic@tieto.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@openwrt.org \
    --cc=sujith@msujith.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).