From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend@broadcom.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"brcm80211 development" <brcm80211-dev-list@broadcom.com>
Subject: Re: brcmfmac: one faulty "iw interface add" command breaks in-firmware BSS state
Date: Mon, 22 Jun 2015 10:23:45 +0200 [thread overview]
Message-ID: <1434961425.19597.7.camel@sipsolutions.net> (raw)
In-Reply-To: <5587C532.3050901@broadcom.com>
On Mon, 2015-06-22 at 10:20 +0200, Arend van Spriel wrote:
> >>> # iw phy phy0 interface add wlan0 type __ap
> Indeed there is an issue with error handling here, but as this was a
> user fault I was looking for early detection. If as you say that will
> not be easy from cfg80211 we will need to rework brcmfmac code.
> Currently, we create interface in firmware and upon receiving 'ifc
> created' event we do the register_netdev. I think we do that to avoid
> getting start_xmit calls as we do not use netif carrier calls.
We could possibly check for duplicate names, but surely there are other
failure modes that we can't easily pre-check, so it seems better to fix
the driver (and, in fact, use the duplicate name issue as a convenient
way of testing the error path)
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
next prev parent reply other threads:[~2015-06-22 8:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-21 19:59 brcmfmac: one faulty "iw interface add" command breaks in-firmware BSS state Rafał Miłecki
2015-06-22 7:47 ` Arend van Spriel
2015-06-22 8:03 ` Johannes Berg
2015-06-22 8:20 ` Arend van Spriel
2015-06-22 8:23 ` Johannes Berg [this message]
2015-06-22 8:06 ` Rafał Miłecki
2015-07-07 21:24 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434961425.19597.7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).