From: Joe Perches <joe@perches.com>
To: David Lin <dlin@marvell.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Chor Teck Law <ctlaw@marvell.com>, Pete Hsieh <peteh@marvell.com>
Subject: Re: [PATCH v4] Add new mac80211 driver mwlwifi.
Date: Mon, 29 Jun 2015 20:16:33 -0700 [thread overview]
Message-ID: <1435634193.9587.64.camel@perches.com> (raw)
In-Reply-To: <cf8d3fa226704acea770a987100f4d4e@SC-EXCH02.marvell.com>
On Tue, 2015-06-30 at 01:49 +0000, David Lin wrote:
> The Linux driver for WRT1900AC. The work was initially developed as part of
> openwrt effort and maintained on https://github.com/kaloz/mwlwifi.
trivia:
Please add terminating newlines to logging messages.
This prevents interleaving output from multiple threads.
> diff --git a/drivers/net/wireless/mwlwifi/fwcmd.c b/drivers/net/wireless/mwlwifi/fwcmd.c
[]
> +static bool mwl_fwcmd_chk_adapter(struct mwl_priv *priv)
> +{
[]
> + if (regval == 0xffffffff) {
> + wiphy_err(priv->hw->wiphy, "adapter is not existed");
wiphy_err(priv->hw->wiphy, "adapter is not existed\n");
> +static int mwl_fwcmd_wait_complete(struct mwl_priv *priv, unsigned short cmd)
> +{
[]
> + if (curr_iteration == 0) {
> + wiphy_err(priv->hw->wiphy, "cmd 0x%04x=%s timed out",
wiphy_err(priv->hw->wiphy, "cmd 0x%04x=%s timed out\n",
etc...
next prev parent reply other threads:[~2015-06-30 3:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 1:49 [PATCH v4] Add new mac80211 driver mwlwifi David Lin
2015-06-30 3:16 ` Joe Perches [this message]
2015-06-30 3:49 ` David Lin
2015-06-30 8:21 ` Johannes Berg
2015-06-30 14:18 ` Dan Williams
2015-06-30 22:26 ` James Cameron
2015-07-01 14:42 ` David Lin
2015-07-01 14:57 ` Johannes Berg
2015-07-01 23:23 ` David Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435634193.9587.64.camel@perches.com \
--to=joe@perches.com \
--cc=ctlaw@marvell.com \
--cc=dlin@marvell.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=peteh@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).