From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
"hostap@lists.shmoo.com" <hostap@lists.shmoo.com>
Subject: Re: Association race when acting as AP?
Date: Thu, 02 Jul 2015 10:38:55 +0200 [thread overview]
Message-ID: <1435826335.2285.6.camel@sipsolutions.net> (raw)
In-Reply-To: <CA+BoTQm==AM3F2Fxq6T_+uY+jq0yXc9JHFT0iwpe2XJrmxkSsg@mail.gmail.com>
[please try to send w/o html if you're CC'ing the linux-wireless list]
> To me this looks like a race in hostapd. The station should be
> installed to driver _before_ sending Assoc Resp frame, not after. My
> quick-n-dirty hack seems to help:
>
[...]
> Is anyone aware of this problem already? Anyone working on it? Any
> gotchas I should be aware of before I go into fixing this in a proper
> way? Or am I missing something and this isn't actually a problem?
The TI folks had a similar patch that broke open networks, not sure
what was wrong there.
Ultimately, depending on the nl80211 capabilities, the station should
in fact be added (as unauthenticated) before even sending the
authentication response frame, and then stepping through the stages
appropriately.
It should also react to errors by sending a negative association
response I guess.
johannes
next parent reply other threads:[~2015-07-02 8:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+BoTQm==AM3F2Fxq6T_+uY+jq0yXc9JHFT0iwpe2XJrmxkSsg@mail.gmail.com>
2015-07-02 8:38 ` Johannes Berg [this message]
2015-07-02 10:28 ` Association race when acting as AP? Michal Kazior
2015-07-02 11:41 ` Johannes Berg
[not found] ` <CAB3XZEf4jC6-au4KQ7SrBtUAyq1LmOqFrT_PLrDZ8ER8ZpR1SA@mail.gmail.com>
2015-07-02 10:39 ` Michal Kazior
2015-07-02 12:45 ` Eliad Peller
2015-07-07 15:00 ` Jouni Malinen
2015-07-09 12:42 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435826335.2285.6.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=hostap@lists.shmoo.com \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).