From: Johannes Berg <johannes@sipsolutions.net>
To: miaoqing@qti.qualcomm.com, linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org, ath9k-devel@qca.qualcomm.com,
kvalo@qca.qualcomm.com
Subject: Re: [PATCH] ath9k: export HW random number generator
Date: Fri, 03 Jul 2015 10:02:57 +0200 [thread overview]
Message-ID: <1435910577.2059.17.camel@sipsolutions.net> (raw)
In-Reply-To: <1435908567-28903-1-git-send-email-miaoqing@qca.qualcomm.com> (sfid-20150703_092941_801781_7DEE1A07)
On Fri, 2015-07-03 at 15:29 +0800, miaoqing@qti.qualcomm.com wrote:
>
> +config ATH9K_HWRNG
> + bool "Random number generator support"
> + depends on ATH9K && (HW_RANDOM = y || HW_RANDOM = ATH9K)
> + default n
you don't need to state 'default n'
> +void ath9k_rng_unregister(struct ath_softc *sc);
> +int ath9k_rng_register(struct ath_softc *sc);
>
unregister before register? not that it matters though.
you're not using the return value, why bother having it?
johannes
prev parent reply other threads:[~2015-07-03 8:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 7:29 [PATCH] ath9k: export HW random number generator miaoqing
2015-07-03 8:02 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435910577.2059.17.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=miaoqing@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).