Re: [PATCH 3/4] iw: Static analyser report that attr may be NULL so either we can remove condition check statement or add goto at end of this function.

[Johannes Berg <johannes@sipsolutions.net>]

On Fri, 2015-06-26 at 09:12 +0000, Amit Khatri wrote:
> Hi Johannes,
> 
> Subject: [PATCH 3/4] iw: Static analyser report that attr may be NULL 
> so
>  either we can remove condition check statement or add goto at end of 
> this
>  function.
> 
That's far far too much for the subject.

Please submit properly formatted patches with a single-line subject and
a more detailed description in the body.

> + out:
> +       ;  /*empty statement to avoid compiler error */
>  }

Just doing "return;" instead of "goto out;" would seem more reasonable
than all these contortions?

johannes